Skip to content

Fix for vtexplain#4413

Merged
demmer merged 4 commits intovitessio:masterfrom
tinyspeck:fix-for-vtexplain
Dec 5, 2018
Merged

Fix for vtexplain#4413
demmer merged 4 commits intovitessio:masterfrom
tinyspeck:fix-for-vtexplain

Conversation

@rafael
Copy link
Copy Markdown
Member

@rafael rafael commented Dec 3, 2018

Description

  • This fixes for the most part the issue described in here: https://vitess.slack.com/archives/C0PQY0PTK/p1543558082021800
  • There are still some corner cases where we see this error. We believe this is due to an issue in tabletservers not shutting down mysql conns cleanly (our mysql client library doesn't do a ComQuit clean shutdown sequence).

Rafael Chacon added 4 commits December 1, 2018 17:22
Make sure tabletserver is shutdown before cleaning up DB
9d73c34 
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
Stop server and also close te/messager/watcher
18e1aa1 
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
This actually stops everything we need
40ef7fe 
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
Refactor place where clanup is done so it's clearer
b654418 
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
@rafael rafael requested a review from sougou as a code owner December 3, 2018 19:18
@demmer demmer merged commit 3f5a312 into vitessio:master Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@demmer demmer demmer approved these changes

@sougou sougou Awaiting requested review from sougou

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rafael @demmer